pass along version to httpd/handler #2928
Conversation
|
Works for me +1. @corylanou? @neonstalwart -- can you show an example response from the server, with this change in place? |
|
I'm on my way out of town but I might be able to do something by Monday. |
| @@ -134,7 +133,7 @@ func (h *Handler) SetRoutes(routes []route) { | |||
| if r.gzipped { | |||
| handler = gzipFilter(handler) | |||
| } | |||
| handler = versionHeader(handler, h.version) | |||
| handler = versionHeader(handler, h) | |||
There was a problem hiding this comment.
I typically prefer to only send what is needed to the receiving method, which in this case is just the version string. It makes the receiving function easy to understand what is actually needed.
|
This looks good. I think we used to have a test that verified the version. I think it got lost in the shuffle. It would be nice to add that back in and make sure it works. Once again, thanks for the work @neonstalwart! +1 |
pass along version to httpd/handler
|
Unfortunately this change does not work. I am looking into a fix. |
|
Fixed by #2969 |
i'm not sure if this is how you want to do this. if there's a way which seems better, let me know and i'll change this.